[rkward] [Bug 400755] New: Factor levels are displayed sorted by string sort, instead of numeric sort of levels.

[Thomas Friedrichsmeier]

https://bugs.kde.org/show_bug.cgi?id=400755

Bug ID: 400755
Summary: Factor levels are displayed sorted by string sort,
instead of numeric sort of levels.
Product: rkward
Version: unspecified
Platform: Other
OS: Linux
Status: REPORTED
Severity: normal
Priority: NOR
Component: User Interface
Assignee: rkward-***@kde.org
Reporter: ***@ruhr-uni-bochum.de
Target Milestone: ---

To reproduce:
x <- data.frame(a=letters)
rk.edit(x)
[click on a cell in the table]
Factor levels are shown "1:a" followed by "10:j".

Likely cause is that we are storing the level key as a string.

[Thomas Friedrichsmeier]

https://bugs.kde.org/show_bug.cgi?id=400755

Thomas Friedrichsmeier <***@ruhr-uni-bochum.de> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|REPORTED |RESOLVED
Resolution|--- |FIXED
Latest Commit| |https://commits.kde.org/rkw
| |ard/1a03828b813c0fb34067b97
| |8da9ff0afe500bb5a

--- Comment #1 from Thomas Friedrichsmeier <***@ruhr-uni-bochum.de> ---
Git commit 1a03828b813c0fb34067b978da9ff0afe500bb5a by Thomas Friedrichsmeier.
Committed on 06/11/2018 at 17:20.
Pushed by tfry into branch 'master'.

Limit number of factor levels to show in popup.

I was a bit too fast in calling that bug fixed, but now it should be:

M +9 -1 rkward/misc/celleditor.cpp

https://commits.kde.org/rkward/1a03828b813c0fb34067b978da9ff0afe500bb5a

[Thomas Friedrichsmeier]

https://bugs.kde.org/show_bug.cgi?id=400755

Thomas Friedrichsmeier <***@ruhr-uni-bochum.de> changed:

What |Removed |Added
----------------------------------------------------------------------------
Resolution|FIXED |---
Status|RESOLVED |REPORTED

--- Comment #2 from Thomas Friedrichsmeier <***@ruhr-uni-bochum.de> ---
Grr. Marked the wrong bug as fixed. Commit below was targeted at bug #380742 .

[m.eik michalke]

https://bugs.kde.org/show_bug.cgi?id=400755

m.eik michalke <***@reaktanz.de> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@reaktanz.de

--- Comment #3 from m.eik michalke <***@reaktanz.de> ---
(In reply to Thomas Friedrichsmeier from comment #0)

Post by Thomas Friedrichsmeier
Likely cause is that we are storing the level key as a string.

also, R 3.5 now internally uses some automatic detection of the "best" sorting
algorithm to use for all kinds of things. i had to update unit test standards
in one of my packages because of this. sorting character values can depend on
the locale set, which if you ask me is a terrible idea if you need reliable
results.