[rkward] [Bug 400545] New: renaming object in workspace doesn't like underscore

[Jan]

https://bugs.kde.org/show_bug.cgi?id=400545

Bug ID: 400545
Summary: renaming object in workspace doesn't like underscore
Product: rkward
Version: unspecified
Platform: Ubuntu Packages
OS: Linux
Status: REPORTED
Severity: normal
Priority: NOR
Component: User Interface
Assignee: rkward-***@kde.org
Reporter: ***@gmx.de
Target Milestone: ---

SUMMARY
RKWard 0.7.0b

STEPS TO REPRODUCE
1. Start RKWard.
2. Create or open R-script.
3. Create an object (e.g. test <- 1).
4. Select object "test" in workspace.
5. Open contextmenu (right mouse click) of object.
6. Select rename (in German "Umbenennen")
7. Give a new name with that includes an underscore, e.g. test_1

OBSERVED RESULT
A message is diplayed: "Der angegebene Name wird bereits verwendet oder ist
nicht gültig. Umbenannt zu test.1"

(My sloppy translation: The given name is used already or not valid. Renamed to
test.1)

EXPECTED RESULT
Object will be renamed to test_1

SOFTWARE VERSIONS
RKWard 0.7.0b
KDE Frameworks 5.44.0
Qt 5.9.5
Kubuntu 18.04

ADDITIONAL INFORMATION
Without problem objects with underscored names can be created (e.g. test_1 <-
1). So it is weird that it isn't possible to rename the object in RKWard.

[Thomas Friedrichsmeier]

https://bugs.kde.org/show_bug.cgi?id=400545

Thomas Friedrichsmeier <***@ruhr-uni-bochum.de> changed:

What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|REPORTED |RESOLVED
Latest Commit| |https://commits.kde.org/rkw
| |ard/a525193f49c5bf76124a28b
| |d80b831f793bb883b

--- Comment #1 from Thomas Friedrichsmeier <***@ruhr-uni-bochum.de> ---
Git commit a525193f49c5bf76124a28bd80b831f793bb883b by Thomas Friedrichsmeier.
Committed on 01/11/2018 at 12:35.
Pushed by tfry into branch 'master'.

Accept underscore in name of new data.frames.

M +1 -0 ChangeLog
M +1 -1 rkward/core/rcontainerobject.cpp

https://commits.kde.org/rkward/a525193f49c5bf76124a28bd80b831f793bb883b